Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qr_code_decoder to launchfile #80

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

P-ict0
Copy link
Contributor

@P-ict0 P-ict0 commented Mar 19, 2024

MatthijsBurgh
MatthijsBurgh previously approved these changes Mar 19, 2024
MatthijsBurgh
MatthijsBurgh previously approved these changes Apr 30, 2024
Copy link
Member

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash this PR

@P-ict0 P-ict0 requested a review from MatthijsBurgh May 14, 2024 19:02
MatthijsBurgh added a commit to tue-robotics/hmi that referenced this pull request May 14, 2024
**After merge, merge also [robot launch files
PR](tue-robotics/robot_launch_files#80) and
[hero_bringup
PR](tue-robotics/hero_bringup#149

Adds QR code reading functionality to hero as a wrapper for an HMI
server.
Aimed for GPSR and EGPSR.

ToDo:

- [x] Remove hardcoded 'hero' from topic list
- [x] Read qr code x times to verify the data
- [x] Check how much of the screen the qr code takes up (to not have
false positives)
- [x] Add maximum tries
- [x] Add pyzbar to the dependencies
- [x] Add to lauchfile
@MatthijsBurgh MatthijsBurgh merged commit 48d7f2f into master May 14, 2024
2 checks passed
@MatthijsBurgh MatthijsBurgh deleted the feat/qr-code-reader branch May 14, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants