west.yml: hal_stm32: Don't include legacy headers anymore #73363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_stm32
DNM
This was referenced May 27, 2024
We're not supposed to rely on symbols provided by these files. In case it is required stm32 zephyr code base should be updated rather than relying on legacy definitions. Additionally: Fixes zephyrproject-rtos#70136 Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
erwango
force-pushed
the
dev/legacy_headers_cleanup
branch
from
acc45aa
to
fd92e96
Compare
ajarmouni-st
approved these changes
Jun 3, 2024
gautierg-st
approved these changes
Jun 3, 2024
erwango
added a commit
to erwango/zephyr
that referenced
this pull request
Jun 17, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
erwango
added a commit
to erwango/zephyr
that referenced
this pull request
Jun 19, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
This was referenced Jun 20, 2024
nashif
pushed a commit
that referenced
this pull request
Jun 21, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for #73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
ekleezg
pushed a commit
to ekleezg/zephyr
that referenced
this pull request
Jun 22, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Jun 26, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. (cherry picked from commit e1b13b6) Original-Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com> GitOrigin-RevId: e1b13b6 Change-Id: I8a505ed45fabc04c49a0043a9fdcd209c7541838 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5649642 Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
fogzot
pushed a commit
to dndg/zephyr
that referenced
this pull request
Jul 23, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not supposed to rely on symbols provided by these files. In case it is required stm32 zephyr code base should be updated rather than relying on legacy definitions.
Additionally:
Fixes #70136