Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projects: Port AD9265-FMC to ZedBoard & doc. #1253

Merged
merged 3 commits into from
Aug 20, 2024
Merged

projects: Port AD9265-FMC to ZedBoard & doc. #1253

merged 3 commits into from
Aug 20, 2024
+2,168 −0

Conversation

cristianmihaipopa
Copy link
Collaborator

@cristianmihaipopa cristianmihaipopa commented Jan 19, 2024 •
edited
Loading

PR Description

projects/ad9265_fmc/zed: Add HDL project to support ad9265_fmc on zed
docs/projects/ad9265_fmc: Add ad9265_fmc project documentation

Link to devicetree: analogdevicesinc/linux#2407

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@IuliaCMoldovan IuliaCMoldovan mentioned this pull request Jan 23, 2024
Merged
gastmaier
gastmaier requested changes Jan 29, 2024
View reviewed changes
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
IuliaCMoldovan
IuliaCMoldovan requested changes Jan 30, 2024
View reviewed changes
docs/projects/ad9265_fmc/index.rst Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9265_fmc/index.rst Outdated Show resolved Hide resolved
projects/ad9265_fmc/zed/system_bd.tcl Outdated Show resolved Hide resolved
projects/ad9265_fmc/zed/system_constr.xdc Show resolved Hide resolved
projects/ad9265_fmc/zed/system_top.v Outdated Show resolved Hide resolved
@IuliaCMoldovan
Copy link
Contributor

Check the messages from the guideline checker action

IuliaCMoldovan
IuliaCMoldovan previously approved these changes Feb 26, 2024
View reviewed changes
@IuliaCMoldovan IuliaCMoldovan dismissed their stale review February 27, 2024 09:09

Needs to be revised

gastmaier
gastmaier previously approved these changes Mar 25, 2024
View reviewed changes
@IuliaCMoldovan IuliaCMoldovan dismissed gastmaier’s stale review April 5, 2024 14:20

The project is failing because of timing constraints not met

@IuliaCMoldovan IuliaCMoldovan changed the title projects: Add AD9265-FMC ZedBoard port & doc. projects: Port AD9265-FMC to ZedBoard & doc. Jul 19, 2024
@IuliaCMoldovan
Copy link
Contributor

Could you first squash all the commits and create 2 (one for project and one for doc)?
Then push this change, and only afterwards to rebase it to main and push it again.

@cristianmihaipopa
projects/ad9265_fmc: New carrier Zedboard
872279e 
- Added support for ZedBoard

Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>
@cristianmihaipopa
docs/projects/ad9265_fmc: Documentation for AD9265 HDL project
8621391 
Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>
@cristianmihaipopa
docs/projects/ad9265_fmc: Fixed the mistakes pointed in the PR
9076859 
Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>
@cristianmihaipopa cristianmihaipopa merged commit 2a54bab into main Aug 20, 2024
1 of 3 checks passed
@cristianmihaipopa cristianmihaipopa deleted the ad9265_zed_port branch August 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@acostina acostina Awaiting requested review from acostina

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

Assignees
No one assigned
Labels
doc newcarrier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristianmihaipopa @IuliaCMoldovan @gastmaier