-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hardware spawner and add tests for it (backport #1759) #1827
Conversation
Cherry-pick of 5dbd6d5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Tests for hardware spawner. * Fully support spawning a list of hardware components * Use python3 coverage instead of ros2 run in tests * Actually check component's state after changing it * Update hardware_spawner's user documentation --------- Co-authored-by: Dr. Denis Štogl <denis@stoglrobotics.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> (cherry picked from commit 5dbd6d5) # Conflicts: # controller_manager/CMakeLists.txt
7161cf4
to
fa1fda7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1827 +/- ##
==========================================
+ Coverage 62.47% 63.15% +0.67%
==========================================
Files 108 109 +1
Lines 12169 12286 +117
Branches 8257 8310 +53
==========================================
+ Hits 7603 7759 +156
+ Misses 884 822 -62
- Partials 3682 3705 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @saikishor for fixing
This basically implements my comments from #1682 (review)
I discussed with @destogl that I would create a new PR including his commit from #1682. So, this effectively replaces #1682.
It basically changes the following things:
is_hardware_component_loaded
checks for one single string, whileactivate_components
andconfigure_components
expect a list.)This is an automatic backport of pull request Fix Hardware spawner and add tests for it #1759 done by Mergify.