-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamic-plugins): make mountpoints and layout declarative #700
Conversation
🦋 Changeset detectedLatest commit: b2ebfb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a7135fe
to
132b4f7
Compare
The image is available at: |
0be8d5b
to
0727d76
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
e2117db
to
6450e7f
Compare
The image is available at: |
6415844
to
d7296cc
Compare
The image is available at: |
d7296cc
to
a08ea87
Compare
The image is available at: |
c9d5bae
to
84daf57
Compare
The image is available at: |
84daf57
to
95a71a4
Compare
The image is available at: |
95a71a4
to
ada1958
Compare
The image is available at: |
ada1958
to
16c20a0
Compare
The image is available at: |
The image is available at: |
d28944a
to
cc57002
Compare
The image is available at: |
cc57002
to
5380a55
Compare
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
011623b
to
8618f5a
Compare
The image is available at: |
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
8618f5a
to
8f32c9c
Compare
… file Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still testing this with the Helm chart, and having errors.
The image is available at: |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use dynamic frontend plugins across the app:
Dynamic routes support home
/
override. You can define additional routes viadynamicPlugins.frontend.dynamicRoutes
- these can't already exists in the app with 1 exception -/
. This allows you to override the home page with your own plugin/component.This change makes
dynamicPlugins.frontend.mountPoints
generic and declarative:Mountpoint now support following names/types:
*/context
mountpoints for React context*/cards
for Card components (with layout)Mountpoint configs:
entity.page.overview
entity.page.topology
entity.page.issues
entity.page.pull-requests
entity.page.ci
entity.page.cd
entity.page.kubernetes
entity.page.tekton
entity.page.image-registry
entity.page.monitoring
entity.page.lighthouse
entity.page.api
entity.page.dependencies
entity.page.docs
entity.page.definition
entity.page.diagram
Mountpoints support following configuration:
layout
for layout features that propagates to allowing users to use CSS properties gridColumnStart including responsiveness queries etc. (mui.com/system/ getting-started/the-sx-prop)if
for EntitySwitch.Case if=... - allows allOf|anyOf|oneOf conditionals with isKind|isType|hasAnnotation builtin methods or code imports via Scalprum (direct string reference)props
to pass additional props to the mounted componentCurrent limitations of the dynamic frontend plugins:
Allows you to mount to existing mountPoints only. You're unable to create additional tabs for example. (will be addressed in a follow up PR)
Kapture.2023-11-03.at.11.33.51.mp4
Known issues:
If a frontend package requires config schema providing
visibility: frontend
annotations, it will fail, since we currently have no means of aggregating it. This renders plugins like Lighthouse unusable at the moment.Which issue(s) does this PR fix
Part of #442
Requires: #699 #683
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer