Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logrotate_fs a generator #1066

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Make logrotate_fs a generator #1066

merged 9 commits into from
Oct 29, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Oct 26, 2024 •
edited
Loading

What does this PR do?

This commit migrates logrotate_fs to be a generator and not a stand-alone binary. While I think it is interesting to consider logrotate_fs as a user defined generator that's more of a rig that needs to be developed than I would like to for this project.

This was referenced Oct 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@blt Graphite App
Copy link
Collaborator Author

blt commented Oct 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blt and the rest of your teammates on Graphite Graphite

This was referenced Oct 26, 2024
Merged
Merged
@blt blt added the no-changelog label Oct 26, 2024 — with Graphite App
@blt blt marked this pull request as ready for review October 26, 2024 00:11
@blt blt requested a review from a team as a code owner October 26, 2024 00:11
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 677d49a to 0842372 Compare October 28, 2024 14:47
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 0842372 to b64551e Compare October 28, 2024 15:53
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from b64551e to 8ba2e64 Compare October 28, 2024 16:31
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 8ba2e64 to 49411e9 Compare October 28, 2024 16:32
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 49411e9 to 9282c06 Compare October 28, 2024 17:21
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 9282c06 to c565f27 Compare October 28, 2024 17:47
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from c565f27 to 7c86467 Compare October 28, 2024 18:27
@blt blt changed the base branch from graphite-base/1066 to main October 29, 2024 01:06
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 695d044 to 2fe78db Compare October 29, 2024 01:06
blt added a commit that referenced this pull request Oct 29, 2024
@blt
Update State::advance_time to be less indented
f41939f 
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
Make logrotate_fs a generator
95f40c8 
This commit migrates logrotate_fs to be a generator and not a stand-alone
binary. While I think it is interesting to consider logrotate_fs as a
user defined generator that's more of a rig that needs to be developed than
I would like to for this project.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
correct tests
f92c433 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
add more telemetry
0b0ffbf 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
correctly backfill new_file with bytes
41a7d7d 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
track max_offset_observed not just bytes_read, duplicate reads
a2ff5bf 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
add created time to file, address bytes written property check fail
acfa0da 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
clippy fixes
f86d308 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt
install necessary lib in main container
0735cf3 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/make_logrotate_fs_a_generator branch from 2fe78db to 0735cf3 Compare October 29, 2024 15:55
blt added a commit that referenced this pull request Oct 29, 2024
@blt
Update State::advance_time to be less indented
f2dae15 
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Oct 29, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@blt
pin package version
18ee493 
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt added a commit that referenced this pull request Oct 29, 2024
@blt
Update State::advance_time to be less indented
2817919 
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt merged commit 913c99b into main Oct 29, 2024
17 checks passed
@blt blt deleted the blt/make_logrotate_fs_a_generator branch October 29, 2024 17:00
blt added a commit that referenced this pull request Oct 29, 2024
@blt
Update State::advance_time to be less indented
bf07a6d 
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt added a commit that referenced this pull request Oct 29, 2024
@blt
Update State::advance_time to be less indented (#1070)
0229a82 
### What does this PR do?

Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.
This was referenced Oct 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@goxberry goxberry goxberry approved these changes

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blt @goxberry