Introduce FileHandle #1063
Merged
Introduce FileHandle #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
This was referenced Oct 25, 2024
Merged
Merged
blt
force-pushed
the
blt/improve_property_tests
branch
from
58a67df
to
c2831b1
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
de63c23
to
6388c1f
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
c2831b1
to
da74cc9
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
6388c1f
to
83a1e46
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
da74cc9
to
3d8cc76
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
83a1e46
to
31b8d54
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
3d8cc76
to
c435364
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
31b8d54
to
0d48b33
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
c435364
to
9c9823d
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
0d48b33
to
0b5d700
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
9c9823d
to
0b4565a
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
0b5d700
to
cf6590f
Compare
blt
force-pushed
the
blt/improve_property_tests
branch
from
0b4565a
to
b4aebbb
Compare
blt
force-pushed
the
blt/introduce_filehandle
branch
from
cf6590f
to
8d0d109
Compare
This was referenced Oct 28, 2024
blt
changed the base branch from
blt/improve_property_tests
to
graphite-base/1063
This commit introduces a FileHandle concept, allowing us to rig the filesystem up so that we can keep track of bytes lost when files are unlinked and then the last fp is closed. Unfortunately as of this commit the property tests are still failing but it's a start. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/introduce_filehandle
branch
from
af0c5ac
to
5bdb252
Compare
blt
force-pushed
the
graphite-base/1063
branch
from
4596868
to
eb78eac
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/introduce_filehandle
branch
from
5bdb252
to
a3a517e
Compare
goxberry
approved these changes
Oct 29, 2024
Merge activity
|
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit introduces a FileHandle concept, allowing us to rig the filesystem
up so that we can keep track of bytes lost when files are unlinked and then
the last fp is closed. Unfortunately as of this commit the property tests
are still failing but it's a start.