Update State::advance_time to be less indented #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
Merged
This was referenced Oct 28, 2024
Merged
Merged
blt
force-pushed
the
blt/make_logrotate_fs_a_generator
branch
from
5cd5d12
to
7041329
Compare
blt
force-pushed
the
blt/update_state_advance_time_to_be_less_indented
branch
from
be91741
to
0731e05
Compare
blt
force-pushed
the
blt/make_logrotate_fs_a_generator
branch
2 times, most recently
from
695d044
to
2fe78db
Compare
blt
force-pushed
the
blt/update_state_advance_time_to_be_less_indented
branch
from
0731e05
to
cb74a84
Compare
goxberry
approved these changes
Oct 29, 2024
blt
force-pushed
the
blt/make_logrotate_fs_a_generator
branch
from
2fe78db
to
0735cf3
Compare
blt
force-pushed
the
blt/update_state_advance_time_to_be_less_indented
branch
2 times, most recently
from
86ef866
to
f5bedb0
Compare
blt
changed the base branch from
blt/make_logrotate_fs_a_generator
to
graphite-base/1070
blt
force-pushed
the
graphite-base/1070
branch
from
18ee493
to
913c99b
Compare
blt
force-pushed
the
blt/update_state_advance_time_to_be_less_indented
branch
from
f5bedb0
to
7217520
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/update_state_advance_time_to_be_less_indented
branch
from
7217520
to
e428e0d
Compare
Merge activity
|
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following @goxberry's PR review on #1057 this PR attempts to remove the
heavy indentation in State::advance_time. Property tests from #1066 still
pass, so I'd say that was solid feedback. The code flows nicer now.