Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mount-point in logrotate-fs start if it does not exist #1079

Merged

Conversation

blt
Copy link
Collaborator

@blt blt commented Oct 29, 2024

What does this PR do?

This commit allows the logrotate_fs to create its mountpoint in the
event that the user has not created the directory ahead of time.

@blt blt marked this pull request as ready for review October 29, 2024 23:29
@blt blt requested a review from a team as a code owner October 29, 2024 23:29
@blt blt force-pushed the blt/make_sure_state_starts_at_close_to_now_tick branch from 56c204c to fb27b08 Compare October 31, 2024 18:27
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from 37934d1 to 8057415 Compare October 31, 2024 18:28
@blt blt mentioned this pull request Oct 31, 2024
@blt blt force-pushed the blt/make_sure_state_starts_at_close_to_now_tick branch from fb27b08 to 811f71c Compare October 31, 2024 19:03
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from 8057415 to 5b008fb Compare October 31, 2024 19:04
@blt blt force-pushed the blt/make_sure_state_starts_at_close_to_now_tick branch from 811f71c to 4b52809 Compare October 31, 2024 19:08
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from 5b008fb to 0dc9edd Compare October 31, 2024 19:08
@blt blt force-pushed the blt/make_sure_state_starts_at_close_to_now_tick branch 2 times, most recently from 4fb2c61 to 82c3b70 Compare October 31, 2024 19:45
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from 0dc9edd to c6c137c Compare October 31, 2024 19:45
@blt blt changed the base branch from blt/make_sure_state_starts_at_close_to_now_tick to graphite-base/1079 October 31, 2024 20:22
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from c6c137c to 0a3c28e Compare October 31, 2024 20:22
@blt blt changed the base branch from graphite-base/1079 to main October 31, 2024 20:22
This commit allows the logrotate_fs to create its mountpoint in the
event that the user has not created the directory ahead of time.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch from 0a3c28e to 02d4074 Compare October 31, 2024 20:23
@blt blt merged commit 9969707 into main Oct 31, 2024
16 checks passed
@blt blt deleted the blt/create_mount-point_in_logrotate-fs_start_if_it_does_not_exist branch October 31, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants