Simulate all ticks, not just some #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
Merged
This was referenced Oct 29, 2024
blt
force-pushed
the
blt/configuration_and_logging_improvements_to_logrotate_fs
branch
2 times, most recently
from
499ee6c
to
cbc702b
Compare
blt
force-pushed
the
blt/simulate_all_ticks_not_just_some
branch
from
6a2ee99
to
bb87d5e
Compare
goxberry
approved these changes
Oct 29, 2024
blt
changed the base branch from
blt/configuration_and_logging_improvements_to_logrotate_fs
to
graphite-base/1075
blt
force-pushed
the
blt/simulate_all_ticks_not_just_some
branch
from
bb87d5e
to
d6b32c2
Compare
blt
force-pushed
the
graphite-base/1075
branch
from
cbc702b
to
063881b
Compare
blt
force-pushed
the
blt/simulate_all_ticks_not_just_some
branch
from
d6b32c2
to
ab43b3f
Compare
This commit adjusts the model to simulate every tick between the previous moment time was advanced and the current moment. This avoids errors where files grow well past the size they should -- demonstrated now with an additional model property. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/simulate_all_ticks_not_just_some
branch
from
ab43b3f
to
8d68c44
Compare
This was referenced Oct 29, 2024
Merge activity
|
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adjusts the model to simulate every tick between the previous
moment time was advanced and the current moment. This avoids errors where
files grow well past the size they should -- demonstrated now with an
additional model property.