Ensure file size updates due to getattr #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
This was referenced Oct 17, 2024
blt
force-pushed
the
blt/update_file_timestamps_to_reflect_real_systemtime
branch
from
0595449
to
0a6e9c0
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
8f3227c
to
3cfa40a
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
3 times, most recently
from
8f3f944
to
854d58d
Compare
blt
force-pushed
the
blt/update_file_timestamps_to_reflect_real_systemtime
branch
from
277331e
to
32ad44c
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
2 times, most recently
from
340087f
to
1d0b1f0
Compare
blt
force-pushed
the
blt/update_file_timestamps_to_reflect_real_systemtime
branch
from
ac43e43
to
b66b30d
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
1d0b1f0
to
8c02a22
Compare
This was referenced Oct 25, 2024
Merged
blt
force-pushed
the
blt/update_file_timestamps_to_reflect_real_systemtime
branch
from
b66b30d
to
ce08cc3
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
8c02a22
to
191bcb0
Compare
blt
force-pushed
the
blt/update_file_timestamps_to_reflect_real_systemtime
branch
2 times, most recently
from
71727dc
to
79cde02
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
191bcb0
to
55b85e2
Compare
goxberry
approved these changes
Oct 28, 2024
blt
changed the base branch from
blt/update_file_timestamps_to_reflect_real_systemtime
to
graphite-base/1042
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
graphite-base/1042
branch
from
79cde02
to
382b730
Compare
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
55b85e2
to
b5e67d9
Compare
This commit ensures that a Node has advance_time called on it when the filesystem calls getattr. If this is not done repeat calls to ls, for instance, will show the file size not changing although a call to read would. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/ensure_file_size_updates_due_to_getattr
branch
from
b5e67d9
to
4206504
Compare
Merge activity
|
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit ensures that a Node has advance_time called on it when
the filesystem calls getattr. If this is not done repeat calls to ls,
for instance, will show the file size not changing although a call to
read would.