Avoid extra name lookup #1044
Merged
Avoid extra name lookup #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
This was referenced Oct 17, 2024
This was referenced Oct 22, 2024
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
06b8ee6
to
d165859
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
3e3abe8
to
df19761
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
d165859
to
7e4aed0
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
df19761
to
eaf4a71
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
7e4aed0
to
54cf3ea
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
eaf4a71
to
9b9a9b3
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
54cf3ea
to
ea176e5
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
9b9a9b3
to
18666dd
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
ea176e5
to
207dd72
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
18666dd
to
1c58312
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
207dd72
to
a03cff4
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
1c58312
to
f1182ba
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
a03cff4
to
5424a84
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
f1182ba
to
4bae0c5
Compare
This was referenced Oct 25, 2024
Merged
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
d62fce9
to
0e316da
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
f029c66
to
762052b
Compare
goxberry
approved these changes
Oct 28, 2024
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
0e316da
to
4fa0e24
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
762052b
to
23f5cf9
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
2 times, most recently
from
68a0760
to
5501775
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
23f5cf9
to
41ba656
Compare
blt
force-pushed
the
blt/allow_readers_to_read_consistently
branch
from
5501775
to
ffae4d1
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
41ba656
to
42034fc
Compare
blt
changed the base branch from
blt/allow_readers_to_read_consistently
to
graphite-base/1044
blt
force-pushed
the
graphite-base/1044
branch
from
ffae4d1
to
e619a9e
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
42034fc
to
10beb10
Compare
This commit avoids an extra name lookup but using the name of an inode as its key in the directory. This will be slightly complicated by rotating files depending on how I do them but it is a win in terms of code simplification now. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
10beb10
to
278aaf9
Compare
Merge activity
|
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit avoids an extra name lookup but using the name of an inode
as its key in the directory. This will be slightly complicated by
rotating files depending on how I do them but it is a win in terms
of code simplification now.