-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Cache
to return a single block
#1037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
This was referenced Oct 22, 2024
blt
force-pushed
the
blt/allow_cache_to_return_a_single_block
branch
from
October 22, 2024 23:50
df8c000
to
56c1824
Compare
In some cases it is valuable for the block cache to be used without `spin`. We expose `next_block` to return a `Block` reference as soon as one is available, blocking the callers meanwhile. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/allow_cache_to_return_a_single_block
branch
from
October 24, 2024 00:10
56c1824
to
48c2b8e
Compare
This was referenced Oct 25, 2024
Merged
goxberry
approved these changes
Oct 28, 2024
Merge activity
|
This was referenced Oct 28, 2024
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some cases it is valuable for the block cache to be used without
spin
.We expose
next_block
to return aBlock
reference as soon as one isavailable, blocking the callers meanwhile.
Motivation
Allow single-threaded applications to read from a block cache.
Ref:
https://datadoghq.atlassian.net/browse/SMPTNG-513