Avoid some allocations, hashes that aren't needed #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
Merged
Merged
Merged
This was referenced Oct 29, 2024
blt
changed the base branch from
blt/simulate_all_ticks_not_just_some
to
graphite-base/1076
blt
force-pushed
the
blt/avoid_some_allocations_hashes_that_aren_t_needed
branch
from
21bd781
to
b4af3bc
Compare
blt
force-pushed
the
graphite-base/1076
branch
from
8d68c44
to
deacbd4
Compare
blt
force-pushed
the
blt/avoid_some_allocations_hashes_that_aren_t_needed
branch
2 times, most recently
from
7ceaf4f
to
e6bc8ca
Compare
This commit removes allocations in the FUSE component that don't need to exist and adjust the interior hashmap to use FxHashMap, avoiding a secure hash in favor of a fast one. Also, directories now keep their children in a BTreeSet so that readdir is always in the same order when called. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/avoid_some_allocations_hashes_that_aren_t_needed
branch
from
e6bc8ca
to
94a0a35
Compare
Merged
goxberry
approved these changes
Oct 31, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes allocations in the FUSE component that don't
need to exist and adjust the interior hashmap to use FxHashMap,
avoiding a secure hash in favor of a fast one. Also, directories
now keep their children in a BTreeSet so that readdir is always
in the same order when called.