Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): shorten generated code for numbers #8864

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Generated output included 0usize, 1usize etc where just 0, 1 is sufficient. Shorten the generated code to aid readability.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8864 will not alter performance

Comparing 02-02-refactor_ast_shorten_generated_code_for_numbers (abfe5bf) with main (4b4d543)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 02-02-refactor_ast_re-order_generated_code to graphite-base/8864 February 3, 2025 20:29
@overlookmotel overlookmotel force-pushed the 02-02-refactor_ast_shorten_generated_code_for_numbers branch from fb1d950 to 121fef5 Compare February 3, 2025 21:52
@overlookmotel overlookmotel changed the base branch from graphite-base/8864 to main February 3, 2025 21:52
@overlookmotel overlookmotel force-pushed the 02-02-refactor_ast_shorten_generated_code_for_numbers branch from 121fef5 to c11ee1a Compare February 3, 2025 21:52
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Generated output included `0usize`, `1usize` etc where just `0`, `1` is sufficient. Shorten the generated code to aid readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant