Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): communicate type of RegExpFlags to oxc_ast_tools with alias type #8868

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Use #[ast(foreign = RegExpFlags)] (introduced in #8866) on a dummy type to tell oxc_ast_tools about the properties of the RegExpFlags type.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 16:25
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8868 will not alter performance

Comparing 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type (6839433) with 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types (768ad4f)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types branch from e219e3f to f0c7c6a Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 6134643 to 07c66df Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types branch from f0c7c6a to eb373ac Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 07c66df to 68ccec4 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types branch from eb373ac to ec98843 Compare February 3, 2025 21:53
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 68ccec4 to 7a2f3eb Compare February 3, 2025 21:54
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

…ith alias type (#8868)

Use `#[ast(foreign = RegExpFlags)]` (introduced in #8866) on a dummy type to tell `oxc_ast_tools` about the properties of the `RegExpFlags` type.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types branch from ec98843 to 768ad4f Compare February 4, 2025 02:50
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 7a2f3eb to 6839433 Compare February 4, 2025 02:50
Base automatically changed from 02-03-refactor_syntax_add_ast_attr_to_semantic_id_types to main February 4, 2025 03:27
@graphite-app graphite-app bot merged commit 6839433 into main Feb 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch February 4, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant