-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools): rename is_visited
to has_visitor
#8893
Merged
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_
Feb 4, 2025
Merged
refactor(ast_tools): rename is_visited
to has_visitor
#8893
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
This was referenced Feb 4, 2025
7070a0f
to
b60fbae
Compare
63ca5de
to
cef5ef1
Compare
Merge activity
|
Pure refactor. Rename `is_visited` to `has_visitor`. The latter describes what it is more clearly. Some types e.g. `Option<Expression>` *are* visited, but they don't have their own visitor method, so having `is_visited = false` is misleading. `has_visitor = false` is more accurate.
b60fbae
to
8de4a23
Compare
cef5ef1
to
84370a9
Compare
Base automatically changed from
02-04-refactor_ast_tools_reorder_code_in_visit_generator
to
main
February 4, 2025 23:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Rename
is_visited
tohas_visitor
. The latter describes what it is more clearly. Some types e.g.Option<Expression>
are visited, but they don't have their own visitor method, so havingis_visited = false
is misleading.has_visitor = false
is more accurate.