Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): rename is_visited to has_visitor #8893

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 4, 2025

Pure refactor. Rename is_visited to has_visitor. The latter describes what it is more clearly. Some types e.g. Option<Expression> are visited, but they don't have their own visitor method, so having is_visited = false is misleading. has_visitor = false is more accurate.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 4, 2025
This was referenced Feb 4, 2025
Copy link
Contributor Author

overlookmotel commented Feb 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@overlookmotel overlookmotel force-pushed the 02-04-refactor_ast_tools_reorder_code_in_visit_generator branch from 7070a0f to b60fbae Compare February 4, 2025 21:56
@overlookmotel overlookmotel force-pushed the 02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_ branch from 63ca5de to cef5ef1 Compare February 4, 2025 21:56
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Pure refactor. Rename `is_visited` to `has_visitor`. The latter describes what it is more clearly. Some types e.g. `Option<Expression>` *are* visited, but they don't have their own visitor method, so having `is_visited = false` is misleading. `has_visitor = false` is more accurate.
@graphite-app graphite-app bot force-pushed the 02-04-refactor_ast_tools_reorder_code_in_visit_generator branch from b60fbae to 8de4a23 Compare February 4, 2025 22:35
@graphite-app graphite-app bot force-pushed the 02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_ branch from cef5ef1 to 84370a9 Compare February 4, 2025 22:35
Base automatically changed from 02-04-refactor_ast_tools_reorder_code_in_visit_generator to main February 4, 2025 23:06
@graphite-app graphite-app bot merged commit 84370a9 into main Feb 4, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_ branch February 4, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant