-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ast_tools): get extra params for visitor methods from #[visit(args)]
attr
#8887
Merged
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr
Feb 4, 2025
Merged
feat(ast_tools): get extra params for visitor methods from #[visit(args)]
attr
#8887
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr
Feb 4, 2025
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
CodSpeed Performance ReportMerging #8887 will not alter performanceComparing Summary
|
This was referenced Feb 4, 2025
This was referenced Feb 4, 2025
2b2b68b
to
f055d92
Compare
c10786c
to
4764a39
Compare
Merge activity
|
…rgs)]` attr (#8887) Instead of hard-coding a special case in the `Visit` codegen for the extra `flags` param to `visit_function`, specify that param in an attribute on the type `#[visit(args(flags = ScopeFlags))] struct Function { ... }`.
f055d92
to
5f5188c
Compare
4764a39
to
c940826
Compare
Base automatically changed from
02-03-refactor_ast_shorten_generated_code_for_getspan_
to
main
February 4, 2025 22:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding a special case in the
Visit
codegen for the extraflags
param tovisit_function
, specify that param in an attribute on the type#[visit(args(flags = ScopeFlags))] struct Function { ... }
.