-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(span): combine Span
type and impls in 1 file
#8900
Merged
graphite-app
merged 1 commit into
main
from
02-04-refactor_span_combine_span_type_and_impls_in_1_file
Feb 5, 2025
Merged
refactor(span): combine Span
type and impls in 1 file
#8900
graphite-app
merged 1 commit into
main
from
02-04-refactor_span_combine_span_type_and_impls_in_1_file
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86d83e9
to
4de0f57
Compare
This was referenced Feb 4, 2025
This was referenced Feb 4, 2025
CodSpeed Performance ReportMerging #8900 will not alter performanceComparing Summary
|
Merge activity
|
80264d4
to
74d5176
Compare
4de0f57
to
c208441
Compare
74d5176
to
f22d18b
Compare
c208441
to
c266c49
Compare
c266c49
to
6eb24da
Compare
f22d18b
to
5cb8466
Compare
6eb24da
to
2b511fa
Compare
2b511fa
to
589d226
Compare
Pure refactor. Combine all code related to `Span` into a single file. The motivation of splitting it into 2 files originally was that `oxc_ast_tools` could not handle `impl`s in same file as type definitions. That restriction is now lifted, so there's no need for the artificial split now.
589d226
to
e930cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Combine all code related to
Span
into a single file.The motivation of splitting it into 2 files originally was that
oxc_ast_tools
could not handleimpl
s in same file as type definitions. That restriction is now lifted, so there's no need for the artificial split now.