-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast): derive ContentEq
on literal types
#8880
Merged
graphite-app
merged 1 commit into
main
from
02-03-refactor_ast_derive_contenteq_on_literal_types
Feb 4, 2025
Merged
refactor(ast): derive ContentEq
on literal types
#8880
graphite-app
merged 1 commit into
main
from
02-03-refactor_ast_derive_contenteq_on_literal_types
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8880 will not alter performanceComparing Summary
|
ef46319
to
ab2b4fd
Compare
b4e18ef
to
f22c5d3
Compare
Merge activity
|
Generate implementations of `ContentEq` trait on literal types instead of writing them manually, using the `#[content_eq(skip)]` attribute introduced in #8875 to skip fields which shouldn't be included.
ab2b4fd
to
04786ac
Compare
f22c5d3
to
571fb70
Compare
Base automatically changed from
02-03-refactor_ast_use_syntax_for_scope_attrs
to
main
February 4, 2025 03:54
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate implementations of
ContentEq
trait on literal types instead of writing them manually, using the#[content_eq(skip)]
attribute introduced in #8875 to skip fields which shouldn't be included.