Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): derive ContentEq on literal types #8880

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Generate implementations of ContentEq trait on literal types instead of writing them manually, using the #[content_eq(skip)] attribute introduced in #8875 to skip fields which shouldn't be included.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 20:25
@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8880 will not alter performance

Comparing 02-03-refactor_ast_derive_contenteq_on_literal_types (571fb70) with 02-03-refactor_ast_use_syntax_for_scope_attrs (ab2b4fd)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_use_syntax_for_scope_attrs branch from ef46319 to ab2b4fd Compare February 3, 2025 21:59
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_derive_contenteq_on_literal_types branch from b4e18ef to f22c5d3 Compare February 3, 2025 21:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link
Member

Boshen commented Feb 4, 2025

Merge activity

  • Feb 3, 9:47 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 9:47 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 10:57 PM EST: A user merged this pull request with the Graphite merge queue.

Generate implementations of `ContentEq` trait on literal types instead of writing them manually, using the `#[content_eq(skip)]` attribute introduced in #8875 to skip fields which shouldn't be included.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_use_syntax_for_scope_attrs branch from ab2b4fd to 04786ac Compare February 4, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants