-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ast): improve TS type definitions for appended fields #8882
Merged
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_improve_ts_type_definitions_for_appended_fields
Feb 4, 2025
Merged
feat(ast): improve TS type definitions for appended fields #8882
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_improve_ts_type_definitions_for_appended_fields
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
This was referenced Feb 3, 2025
1bf4794
to
c09d4f6
Compare
ee40942
to
f0ea8d6
Compare
c09d4f6
to
d7945c7
Compare
f0ea8d6
to
9b10ee8
Compare
This was referenced Feb 4, 2025
This was referenced Feb 4, 2025
d7945c7
to
3f1006b
Compare
9b10ee8
to
12c5395
Compare
Merge activity
|
Cosmetic change. Preserve original order of fields in TS type definitions where a field is appended to a collection (e.g. `ObjectPattern`). If someone is consulting the type definitions, it makes more sense having the appended type listed last. e.g. `Array<BindingProperty | BindingRestElement>`, not the other way around.
3f1006b
to
2eb6594
Compare
12c5395
to
53ee053
Compare
Base automatically changed from
02-03-refactor_ast_tools_parse_attributes_more_deeply
to
main
February 4, 2025 22:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic change. Preserve original order of fields in TS type definitions where a field is appended to a collection (e.g.
ObjectPattern
). If someone is consulting the type definitions, it makes more sense having the appended type listed last. e.g.Array<BindingProperty | BindingRestElement>
, not the other way around.