Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast): improve TS type definitions for appended fields #8882

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Cosmetic change. Preserve original order of fields in TS type definitions where a field is appended to a collection (e.g. ObjectPattern). If someone is consulting the type definitions, it makes more sense having the appended type listed last. e.g. Array<BindingProperty | BindingRestElement>, not the other way around.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 20:28
@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Feb 3, 2025
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from 1bf4794 to c09d4f6 Compare February 3, 2025 22:00
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch from ee40942 to f0ea8d6 Compare February 3, 2025 22:01
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from c09d4f6 to d7945c7 Compare February 4, 2025 09:26
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch from f0ea8d6 to 9b10ee8 Compare February 4, 2025 09:26
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

Cosmetic change. Preserve original order of fields in TS type definitions where a field is appended to a collection (e.g. `ObjectPattern`). If someone is consulting the type definitions, it makes more sense having the appended type listed last. e.g. `Array<BindingProperty | BindingRestElement>`, not the other way around.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_tools_parse_attributes_more_deeply branch from 3f1006b to 2eb6594 Compare February 4, 2025 22:00
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch from 12c5395 to 53ee053 Compare February 4, 2025 22:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Base automatically changed from 02-03-refactor_ast_tools_parse_attributes_more_deeply to main February 4, 2025 22:21
@graphite-app graphite-app bot merged commit 53ee053 into main Feb 4, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ast_improve_ts_type_definitions_for_appended_fields branch February 4, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant