Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): use = syntax for #[scope] attrs #8878

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Change the attributes which specify the scope flags for types from #[scope(flags(ScopeFlags::Class)] to #[scope(flags = ScopeFlags::Class)]. Ditto strict_if. This makes their syntax consistent with other attributes, and will allow simplifying attribute parsing.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 19:11
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8878 will not alter performance

Comparing 02-03-refactor_ast_use_syntax_for_scope_attrs (04786ac) with 02-03-refactor_ast_move_estree_skip_to_types (6628e1d)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 00d3f39 to 3df6dae Compare February 3, 2025 20:23
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_use_syntax_for_scope_attrs branch from de94780 to ef46319 Compare February 3, 2025 20:23
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 3df6dae to 3c771fc Compare February 3, 2025 21:58
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_use_syntax_for_scope_attrs branch from ef46319 to ab2b4fd Compare February 3, 2025 21:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

Change the attributes which specify the scope flags for types from `#[scope(flags(ScopeFlags::Class)]` to `#[scope(flags = ScopeFlags::Class)]`. Ditto `strict_if`. This makes their syntax consistent with other attributes, and will allow simplifying attribute parsing.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_move_estree_skip_to_types branch from 3c771fc to 6628e1d Compare February 4, 2025 02:54
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_use_syntax_for_scope_attrs branch from ab2b4fd to 04786ac Compare February 4, 2025 02:55
Base automatically changed from 02-03-refactor_ast_move_estree_skip_to_types to main February 4, 2025 03:51
@graphite-app graphite-app bot merged commit 04786ac into main Feb 4, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_use_syntax_for_scope_attrs branch February 4, 2025 03:54
graphite-app bot pushed a commit that referenced this pull request Feb 4, 2025
After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of `syn` types from code generators - they now work entirely with `oxc_ast_tools`'s types (which are simpler).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant