fix(ast): fix lifetimes on custom Serialize impls
#8899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8899 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-04-fix_ast_fix_lifetimes_on_custom_serialize_impls
branch
from
008cc3d to
2ed22ae
Compare
overlookmotel
changed the base branch from
main
to
02-04-refactor_span_combine_span_type_and_impls_in_1_file
This was referenced Feb 5, 2025
This was referenced Feb 5, 2025
overlookmotel
force-pushed
the
02-04-refactor_span_combine_span_type_and_impls_in_1_file
branch
2 times, most recently
from
2b511fa to
589d226
Compare
overlookmotel
force-pushed
the
02-04-fix_ast_fix_lifetimes_on_custom_serialize_impls
branch
2 times, most recently
from
9aa8bb5 to
49433c4
Compare
overlookmotel
changed the base branch from
02-04-refactor_span_combine_span_type_and_impls_in_1_file
to
main
Merge activity
|
graphite-app
bot
force-pushed
the
02-04-fix_ast_fix_lifetimes_on_custom_serialize_impls
branch
from
49433c4 to
10eb784
Compare
graphite-app
bot
force-pushed
the
02-04-fix_ast_fix_lifetimes_on_custom_serialize_impls
branch
from
10eb784 to
315fec6
Compare
graphite-app
bot
deleted the
02-04-fix_ast_fix_lifetimes_on_custom_serialize_impls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lifetimes on custom
Serializeimpls for literal types. It's not required to borrow the AST node for'a, only that it's inner allocator lifetime is'a. The longer lifetime requirement was unnecessarily restrictive.