-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(span)!: export ContentEq
trait from root of oxc_span
crate
#8869
Merged
graphite-app
merged 1 commit into
main
from
02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate
Feb 4, 2025
Merged
refactor(span)!: export ContentEq
trait from root of oxc_span
crate
#8869
graphite-app
merged 1 commit into
main
from
02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8869 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
6134643
to
07c66df
Compare
d11853d
to
64c913b
Compare
This was referenced Feb 3, 2025
07c66df
to
68ccec4
Compare
64c913b
to
344d6e1
Compare
This was referenced Feb 3, 2025
This was referenced Feb 3, 2025
68ccec4
to
7a2f3eb
Compare
344d6e1
to
435aca3
Compare
Merge activity
|
…te (#8869) Export `ContentEq` as `oxc_span::ContentEq`. Previously was within a sub-module `oxc_span::cmp::ContentEq`. This made sense when we also had `ContentHash`, but now that's removed, it makes more sense for `ContentEq` to be exported from root of the crate.
7a2f3eb
to
6839433
Compare
435aca3
to
b7ff7e1
Compare
Base automatically changed from
02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type
to
main
February 4, 2025 03:29
This was referenced Feb 4, 2025
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast
Area - AST
A-ast-tools
Area - AST tools
A-linter
Area - Linter
A-minifier
Area - Minifier
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
ContentEq
asoxc_span::ContentEq
. Previously was within a sub-moduleoxc_span::cmp::ContentEq
. This made sense when we also hadContentHash
, but now that's removed, it makes more sense forContentEq
to be exported from root of the crate.