Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(span)!: export ContentEq trait from root of oxc_span crate #8869

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Export ContentEq as oxc_span::ContentEq. Previously was within a sub-module oxc_span::cmp::ContentEq. This made sense when we also had ContentHash, but now that's removed, it makes more sense for ContentEq to be exported from root of the crate.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-minifier Area - Minifier A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 3, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 16:27
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8869 will create unknown performance changes

Comparing 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate (b7ff7e1) with 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type (6839433)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 24.8 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 723.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.5 µs N/A
🆕 lexer[antd.js] N/A 22 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.8 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 296.3 µs N/A
🆕 mangler[typescript.js] N/A 39.9 ms N/A
🆕 minifier[antd.js] N/A 157.4 ms N/A
🆕 minifier[react.development.js] N/A 1.6 ms N/A
🆕 minifier[typescript.js] N/A 270 ms N/A
🆕 estree[checker.ts] N/A 207.5 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.6 µs N/A
🆕 parser[antd.js] N/A 106.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 6134643 to 07c66df Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from d11853d to 64c913b Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 07c66df to 68ccec4 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 64c913b to 344d6e1 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 68ccec4 to 7a2f3eb Compare February 3, 2025 21:54
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 344d6e1 to 435aca3 Compare February 3, 2025 21:55
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

…te (#8869)

Export `ContentEq` as `oxc_span::ContentEq`. Previously was within a sub-module `oxc_span::cmp::ContentEq`. This made sense when we also had `ContentHash`, but now that's removed, it makes more sense for `ContentEq` to be exported from root of the crate.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type branch from 7a2f3eb to 6839433 Compare February 4, 2025 02:50
@graphite-app graphite-app bot force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 435aca3 to b7ff7e1 Compare February 4, 2025 02:51
Base automatically changed from 02-03-refactor_ast_communicate_type_of_regexpflags_to_oxc_ast_tools_with_alias_type to main February 4, 2025 03:29
@graphite-app graphite-app bot merged commit b7ff7e1 into main Feb 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch February 4, 2025 03:33
This was referenced Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-linter Area - Linter A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant