slack project ts 2019 08 05
| Time | Icon | Name | Message |
|---|---|---|---|
| 10:58 |  |
shinyu | Finished JS-to-TS migration work https://github.com/vivliostyle/vivliostyle.js/pull/536 Thanks @spring-raining and @Johannes WilmJS-to-TS migration: <https://github.com/vivliostyle/vivliostyle.js/milestone/1 |
| 11:00 |  |
Johannes Wilm | ok, vivliostyle-print probably needs to be updated after you make a release of this |
| 14:54 | |
shinyu | Merged to master, and vivliostyle-viewer on github pages is updated, but … Something broken, HTML <head> content appears in the page. https://vivliostyle.github.io/vivliostyle.js/viewer/vivliostyle-viewer.html#x=../samples/gutenberg/Alice.html I could not find this problem in my local dev environment. I’m going to debug…. |
| 15:46 | |
shinyu | Fixed https://github.com/vivliostyle/vivliostyle.js/commit/fe24ad9ea601dc3bfa2791402cbd1691dd1b1547 |
| 16:09 | |
Johannes Wilm | Great! I was actually wondering about something related - why exactly do we require the app to download specific files from URLs later on? That makes it quite a bit more complicated to run as a dependency. |
| 16:09 | |
Johannes Wilm | if the reason is to keep the size down, I would recommend using dynamic imports instead. then a bundler can turn that into code splitting. |
| 16:10 | |
Johannes Wilm | In this case - why are we downloading the user-agent-base.css file later on rather than storing the contents of the file in a string from the beginning? |
| 16:11 | |
Johannes Wilm | btw - what a great job! |